[patch] Add standalone Db2uCluster to Db2uInstance migration pipeline and CLI command - #2428
Draft
jainyjoseph wants to merge 25 commits into
Draft
jainyjoseph wants to merge 25 commits into
jainyjoseph wants to merge 25 commits into
Conversation
terc1997
requested changes
Sep 15, 2026
terc1997
left a comment
Contributor
There was a problem hiding this comment.
In the PRs ansible-devops and python-devops there are several names for this migration: db2-migration, migrate, db2ucluster-migration. Stick to one name and use it in all places. Having multiple naming conventions create confusion in the code.
Also, there are several mentions to cluster in these three PRs. While in the context of the Db2 migration it means Db2uCluster someone not involved into this initiative may misinterpret these variable names. So, update all cluster references to actual db2_cluster to avoid confusion. Always prioritize clarity over size of the name.
Comment on lines
+49
to
+70
| # 1. Wait for approval (auto-approved) | ||
| # ------------------------------------------------------------------------- | ||
| #- name: waitfor-approval | ||
| # timeout: "0" | ||
| # taskRef: | ||
| # kind: Task | ||
| # name: mas-devops-wait-for-configmap-v2 | ||
| # params: | ||
| # - name: image_pull_policy | ||
| # value: $(params.image_pull_policy) | ||
| # - name: configmap_name | ||
| # value: approval-db2-migration | ||
| # - name: configmap_initial_value | ||
| # value: approved | ||
| # - name: pipeline_status | ||
| # value: Started | ||
| # - name: pipeline_name | ||
| # value: $(context.pipeline.name) | ||
| # - name: pipelinerun_name | ||
| # value: $(context.pipelineRun.name) | ||
| # - name: pipelinerun_namespace | ||
| # value: $(context.pipelineRun.namespace) |
|
|
||
| # Detect clusters | ||
| with Halo(text=f"Detecting Db2uClusters in namespace {namespace}", spinner=self.spinner) as h: | ||
| clusters = self.detectDb2uClusters(namespace) |
Contributor
There was a problem hiding this comment.
rename clusters to db2_clusters for clarity.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new standalone Tekton pipeline and CLI command for migrating Db2uCluster instances to Db2uInstance
Changes
New CLI command(mas db2ucluster-migration)
New Tekton Pipeline
Key features
Test results
You can refer test results in JIRA MASCORE-11096
Refer : ibm-mas/ansible-devops#2337
ibm-mas/python-devops#405